Skip to content

Conversation

@xingzhougmu
Copy link

I add Radio buttons to let users to choose if they are working with
Global Azure or Mooncake. By default the Global Azure option is checked.

And the Add AzureEnvironment varible to differentiate it. This variable
will be used when creating service client since the service endpoints
are different from Global Azure and Mooncake.

I add Radio buttons to let users to choose if they are working with
Global Azure or Mooncake. By default the Global Azure option is checked.

And the Add AzureEnvironment varible to differentiate it. This variable
will be used when creating service client since the service endpoints
are different from Global Azure and Mooncake.
@msftclas
Copy link

Hi @xingzhougmu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@xingzhougmu
Copy link
Author

Hi @msftclas,

I have followed the instructions you sent to me and completed CLA.

Thanks,
Xing

@huxuan
Copy link

huxuan commented Nov 24, 2016

Hi @xingzhougmu, thanks for your interests and contribution.

As this is just a demo of Cognitive Service Face API, I am not sure whether it is necessary to support different Azure regions as we may have more instances in different places (like Europe) in the future. This will cost more extra efforts for maintenance.

And for your pull request, I don't think it actually calls the Azure China instance. Seems there are two AzureEnvironment properties added. Are you sure this pull request is ready for review?

@xingzhougmu
Copy link
Author

Hi @huxuan ,

Yes, currently I only added two environments "Global Azure" and "Mooncake".

And I will use the environment to set different service endpoint in this project.

Cheers,
Xing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants