Conversation
84c1fdf to
c1296b1
Compare
|
Excellent! I've yet to get into using cmake - it's very nice to see someone have a go at it. |
|
I'm open to moving to cmake if there are advantages to such a move. I know a lot of projects use it so there must be some reason =) I really don't know that much about the topic. My opinion at this point is that the Makefile seems to work just fine for what I've wanted to do with Attract-Mode. I'm biased due to having spent a lot of time learning how to get the Makefile working for this project, and now cmake looks like a whole other world to figure out ... I think it would have to be a clean switch, we should go with one or the other and not have to maintain both cmake and a separate makefile |
|
The big benefit that I can see is its much easier to read and debug. Not having to deal as much with the different system/arch dependencies is nice too. This was my first trial of cmake, so don't judge it to harshly based on this PR :) I'll keep working on it. There's a lot to clean up. |
|
Lots of updates. Should be complete with support for all existing options and behavior. |
|
great, I'm hoping to get around to reviewing this and your ffmpeg patch soon.
|
30f9df3 to
5ee7efc
Compare
|
cleaned up a bit and squashed. |
cmake .. && make deb
|
Successfully tested on a RPi2, Raspian Jessie, basically following the wiki instructions. |
a8aea79 to
fbf02e9
Compare
109e6d5 to
2a56dab
Compare
found compiling on raspbian buckeye interface libs do not have sources
As I have been working on a cross-platform buildbot, it has become increasingly difficult with the current makefile.
Pull request is for soliciting feedback (good or bad).