Add nonce to Script tag loading api.js to ensure it works when script dynamic set on content security ploicy header #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dynamic set on content security ploicy header michaelvs97#74
sleeuwen
requested changes
Jul 7, 2025
Collaborator
sleeuwen
left a comment
sleeuwen
left a comment
There was a problem hiding this comment.
Thanks for the PR! I just have some small concerns on using AppendHtml instead of AppendFormat. If you can change that I'd be happy to merge it
Used method to add nonce to V3 and V2 script tags Added test for empty nonce
Author
|
I hope this is a suitable resolution. I have also added some characters to the nonce value in the test to prove the encoding is being applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#74