fix: sign id is not globally unique #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The sign id returned by sign_place() is buffer-local, so the ids of signs in different buffers can be the same. Due to this, set_breakpoint with condition overrides condition of another breakpoint in another buffer. Solution: * Maintain mapping of buffer → sign id → breakpoint. * Also fix other issues with wrong fields of bp.
Contributor
Author
|
lint failure seems unrelated to this pr |
Owner
|
Thanks, nice catch. A bit surprised that I haven't noticed this for so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The sign id returned by sign_place() is buffer-local, so the ids of
signs in different buffers can be the same. Due to this, set_breakpoint
with condition overrides condition of another breakpoint in another
buffer.
Solution: