Skip to content

Fix: Upgrading helm3 and updating delete command to uninstall. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qeon wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Upgrading helm3 and updating delete command to uninstall. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bafd28e
Upgrade helm3 to v3.12.2
qeon Aug 7, 2023
2426008
Merge pull request #1 from qeon/feat-upgrade-helm
qeon Aug 7, 2023
2333215
Fix: Change 'delete' argument to 'uninstall'.
qeon Aug 7, 2023
22c52db
Merge pull request #2 from qeon/fix-delete-cmd
qeon Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM alpine:3.15
ENV BASE_URL="https://get.helm.sh"

ENV HELM_2_FILE="helm-v2.17.0-linux-amd64.tar.gz"
ENV HELM_3_FILE="helm-v3.4.2-linux-amd64.tar.gz"
ENV HELM_3_FILE="helm-v3.12.2-linux-amd64.tar.gz"

RUN apk add --no-cache ca-certificates \
--repository http://dl-cdn.alpinelinux.org/alpine/v3.15/community \
Expand Down
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ function renderFiles(files, data) {
*/
function deleteCmd(helm, namespace, release) {
if (helm === "helm3") {
return ["delete", "-n", namespace, release];
return ["uninstall", "-n", namespace, release];
}
return ["delete", "--purge", release];
return ["uninstall", "--purge", release];
}

/**
Expand Down