Add acceptance test data for stochastic noise #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gavinevans
requested changes
Jan 16, 2026
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @maxwhitemet 👍
It would be good to add a visualisation of these files. I think that this would highlight the issue with the units in the KGO, where the file metadata says m/s, but the values are actually mm/hr, so this needs correcting.
Manually correcting the units, the input and KGO looks like below:
Contributor
Author
|
Here are plots of the new acceptance test data input and output. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test data relevant to the IMPROVER PR #953, addressing ticket #953.