Modify SAMOS internal rolling window to use trailing window #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow. Add unit tests.
…_window_type argument available in relevant CLIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/991
This PR adds provides additional functionality to the internal TrainGAMsForSAMOS class. At the moment, this class includes a method which calculates means and standard deviations via a rolling window calculation over the training data. This method uses a centred rolling window, so that the result of the calculation is assigned to the central datetime in that window. This PR adds the option of using a 'trailing' rolling window instead, so that the result of the calculation is assigned to the end of the window.
The new functionality is exposed in related CLIs through a new
rolling_window_typeoption. The default behaviour throughout is to use the centered rolling window.Testing: