3002.rose edit.traceback#3003
Merged
oliver-sanders merged 3 commits intometomi:masterfrom Feb 13, 2026
Merged
Conversation
…creen process will cause traceback
oliver-sanders
approved these changes
Feb 13, 2026
Member
oliver-sanders
left a comment
oliver-sanders
left a comment
There was a problem hiding this comment.
Reproduced and confirmed as fixed 👍
Member
|
(lint error to fix) |
wxtim
commented
Feb 13, 2026
wxtim
commented
Feb 13, 2026
wxtim
commented
Feb 13, 2026
|
|
||
| # Don't run a real process: | ||
|
|
||
|
|
wxtim
force-pushed
the
3002.rose-edit.traceback
branch
from
a77b354 to
20276d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3002
Turns out that if you try to close the splash screen twice you get traceback. I've added a handler to make this safer rather than trying to fix the circumstances in which it gets called twice.