refactor: replace better-result with faultier for error handling by adelrodriguez · Pull Request #94 · metaideas/init

adelrodriguez · 2026-02-19T03:10:43Z

Greptile Summary

This PR successfully migrates the error handling system from better-result to faultier. The refactor is complete and correctly implements the new API, including updating all error class definitions to use Faultier.Tagged, introducing fault registries for each error domain (AuthFault, EmailFault, UtilityFault), and merging them into a unified AppFault registry.

Key changes:

Replaced better-result dependency with faultier@2.2.0 in package.json
Updated all error imports from import { TaggedError } from "better-result" to import * as Faultier from "faultier"
Migrated error class definitions from TaggedError(...) to Faultier.Tagged(...)
Fixed tag name inconsistencies (AuthenticationError → UnauthenticatedError, AuthorizationError → UnauthorizedError)
Removed constructor-based custom messages in favor of .withMessage() method calls
Created fault registries using Faultier.registry() for better error handling organization
Added new InvalidBaseUrlError utility error
Exported faultier utilities (matchTag, matchTags, Fault) from the main index

The migration correctly adapts to faultier's API differences, particularly the builder pattern for adding messages via .withMessage() rather than constructor arguments.

Confidence Score: 5/5

This PR is safe to merge with no blocking issues
The refactor is complete and thorough. All imports have been updated correctly, the API migration follows faultier's documented patterns, error registries are properly created and merged, and existing error usage sites have been updated to use the new .withMessage() API. The changes maintain backward compatibility in terms of exported types and error behavior.
No files require special attention

Important Files Changed

Filename	Overview
packages/error/package.json	Updated dependency from `better-result` to `faultier@2.2.0`
packages/error/src/utils.ts	Migrated to `Faultier.Tagged`, removed constructor custom messages, added `UtilityFault` registry and new `InvalidBaseUrlError`
packages/error/src/auth.ts	Migrated to `Faultier.Tagged`, fixed tag names to match class names, added `AuthFault` registry
packages/error/src/email.ts	Migrated to `Faultier.Tagged` and added `EmailFault` registry
packages/error/src/index.ts	Merged fault registries into `AppFault`, exported faultier utilities (`matchTag`, `matchTags`, `Fault`)
packages/utils/src/assert.ts	Updated error instantiation to use `.withMessage()` method instead of passing message in constructor

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[better-result] -->|Replaced with| B[faultier]
    B --> C[Tagged errors]
    C --> D[utils.ts errors]
    C --> E[auth.ts errors]
    C --> F[email.ts errors]
    D --> G[UtilityFault registry]
    E --> H[AuthFault registry]
    F --> I[EmailFault registry]
    G --> J[AppFault]
    H --> J
    I --> J
    J --> K[Exported from index.ts]
    L[assert.ts] -->|Uses| M[.withMessage method]
    M -->|New API| B

_{Last reviewed commit: ae5df0e}

coderabbitai · 2026-02-19T03:10:51Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 02-18-refactor_replace_better-result_with_faultier_for_error_handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

adelrodriguez · 2026-02-19T03:10:53Z

refactor: replace better-result with faultier for error handling #94 : 2 dependent PRs (#95 , #98 ) 👈 (View in Graphite)
refactor: move MOBILE_BREAKPOINT from utils to ui package #93
refactor: move THEMES constant from utils to ui package #92
refactor: move environment prefix constants from utils to env package #91
feat: replace custom duration utils with qte library #90
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

_{2 files reviewed, 11 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-19T03:14:44Z

packages/error/src/utils.ts

Import still references better-result but the dependency was changed to faultier. This will cause a module not found error.

Suggested change

import { Tagged } from "faultier"

Note: faultier exports Tagged instead of TaggedError. You'll need to update all usages accordingly.

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/utils.ts Line: 1 Comment: Import still references `better-result` but the dependency was changed to `faultier`. This will cause a module not found error. ```suggestion import { Tagged } from "faultier" ``` Note: `faultier` exports `Tagged` instead of `TaggedError`. You'll need to update all usages accordingly. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:45Z

packages/error/src/auth.ts

Import still references better-result but the dependency was changed to faultier.

Suggested change

import { Tagged } from "faultier"

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/auth.ts Line: 1 Comment: Import still references `better-result` but the dependency was changed to `faultier`. ```suggestion import { Tagged } from "faultier" ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:46Z

packages/error/src/email.ts

Import still references better-result but the dependency was changed to faultier.

Suggested change

import { Tagged } from "faultier"

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/email.ts Line: 1 Comment: Import still references `better-result` but the dependency was changed to `faultier`. ```suggestion import { Tagged } from "faultier" ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:47Z

packages/error/src/utils.ts

TaggedError needs to be replaced with Tagged to match faultier's API.

Suggested change

export class InvalidDurationParseInputError extends Tagged("InvalidDurationParseInputError")<{

message: string

value: string

}>() {

constructor(props: { value: string }) {

super({ ...props, message: `Unable to parse duration from input: "${props.value}"` })

}

}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/utils.ts Line: 3-10 Comment: `TaggedError` needs to be replaced with `Tagged` to match `faultier`'s API. ```suggestion export class InvalidDurationParseInputError extends Tagged("InvalidDurationParseInputError")<{ message: string value: string }>() { constructor(props: { value: string }) { super({ ...props, message: `Unable to parse duration from input: "${props.value}"` }) } } ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:48Z

packages/error/src/utils.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class InvalidDurationFormatInputError extends Tagged(

"InvalidDurationFormatInputError"

)<{ message: string }>() {

constructor() {

super({ message: "Invalid duration format provided" })

}

}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/utils.ts Line: 12-18 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class InvalidDurationFormatInputError extends Tagged( "InvalidDurationFormatInputError" )<{ message: string }>() { constructor() { super({ message: "Invalid duration format provided" }) } } ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:50Z

packages/error/src/utils.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class AssertConditionFailedError extends Tagged("AssertConditionFailedError")<{

message: string

condition: string

}>() {}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/utils.ts Line: 24-27 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class AssertConditionFailedError extends Tagged("AssertConditionFailedError")<{ message: string condition: string }>() {} ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:51Z

packages/error/src/auth.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class UnauthenticatedError extends Tagged("AuthenticationError")() {}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/auth.ts Line: 3 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class UnauthenticatedError extends Tagged("AuthenticationError")() {} ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:52Z

packages/error/src/auth.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class UnauthorizedError extends Tagged("AuthorizationError")<{ userId: string }>() {}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/auth.ts Line: 5 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class UnauthorizedError extends Tagged("AuthorizationError")<{ userId: string }>() {} ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:53Z

packages/error/src/email.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class SendEmailError extends Tagged("SendEmailError")<{

emails: string[]

subject: string

from?: string

text: string

}>() {}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/email.ts Line: 3-8 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class SendEmailError extends Tagged("SendEmailError")<{ emails: string[] subject: string from?: string text: string }>() {} ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-19T03:14:54Z

packages/error/src/email.ts

TaggedError needs to be replaced with Tagged.

Suggested change

export class BatchSendEmailError extends Tagged("BatchSendEmailError")<{

emails: string[]

subject: string

from?: string

}>() {}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/error/src/email.ts Line: 10-14 Comment: `TaggedError` needs to be replaced with `Tagged`. ```suggestion export class BatchSendEmailError extends Tagged("BatchSendEmailError")<{ emails: string[] subject: string from?: string }>() {} ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

packages/error/package.json

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

packages/error/package.json

This was referenced Feb 19, 2026

refactor: move MOBILE_BREAKPOINT from utils to ui package #93

Merged

refactor: move environment prefix constants from utils to env package #91

Merged

refactor: move THEMES constant from utils to ui package #92

Merged

adelrodriguez marked this pull request as ready for review February 19, 2026 03:10

adelrodriguez mentioned this pull request Feb 19, 2026

feat: replace custom duration utils with qte library #90

Merged

adelrodriguez mentioned this pull request Feb 19, 2026

refactor: move storage types from utils to storage package #95

Merged

greptile-apps bot reviewed Feb 19, 2026

View reviewed changes

adelrodriguez mentioned this pull request Feb 19, 2026

refactor: move I18N_COOKIE_NAME to @tooling/internationalization package #96

Merged

adelrodriguez force-pushed the 02-18-refactor_move_mobile_breakpoint_from_utils_to_ui_package branch from 058dcb0 to 8973883 Compare February 19, 2026 03:24

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch from ef7ac57 to 7507d4a Compare February 19, 2026 03:25

greptile-apps bot reviewed Feb 19, 2026

View reviewed changes

packages/error/package.json Show resolved Hide resolved

adelrodriguez force-pushed the 02-18-refactor_move_mobile_breakpoint_from_utils_to_ui_package branch from 8973883 to bf8d6d6 Compare February 19, 2026 03:29

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch from 7507d4a to b8577bc Compare February 19, 2026 03:29

adelrodriguez mentioned this pull request Feb 19, 2026

refactor: move auth constants from utils to auth package #97

Merged

adelrodriguez force-pushed the 02-18-refactor_move_mobile_breakpoint_from_utils_to_ui_package branch 2 times, most recently from eac8e82 to acb844a Compare February 19, 2026 03:33

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch from b8577bc to 3f35747 Compare February 19, 2026 03:33

greptile-apps bot reviewed Feb 19, 2026

View reviewed changes

packages/error/package.json Show resolved Hide resolved

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch from 3f35747 to 194a280 Compare February 19, 2026 03:38

adelrodriguez mentioned this pull request Feb 19, 2026

feat: add fault serialization adapter for react-router #98

Merged

adelrodriguez changed the base branch from 02-18-refactor_move_mobile_breakpoint_from_utils_to_ui_package to graphite-base/94 February 19, 2026 03:52

adelrodriguez force-pushed the graphite-base/94 branch from acb844a to 46efd08 Compare February 19, 2026 03:52

refactor: replace better-result with faultier for error handling

ae5df0e

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch from 194a280 to 82e83d3 Compare February 19, 2026 03:52

graphite-app bot changed the base branch from graphite-base/94 to main February 19, 2026 03:53

adelrodriguez force-pushed the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch 3 times, most recently from 39ff9b8 to ae5df0e Compare February 19, 2026 03:53

coderabbitai bot approved these changes Feb 19, 2026

View reviewed changes

adelrodriguez merged commit 562f8f7 into main Feb 19, 2026
7 checks passed

adelrodriguez deleted the 02-18-refactor_replace_better-result_with_faultier_for_error_handling branch February 19, 2026 03:58

+export class InvalidDurationParseInputError extends Tagged("InvalidDurationParseInputError")<{
+  message: string
+  value: string
+}>() {
+  constructor(props: { value: string }) {
+    super({ ...props, message: `Unable to parse duration from input: "${props.value}"` })
+  }
+}

+export class InvalidDurationFormatInputError extends Tagged(
+  "InvalidDurationFormatInputError"
+)<{ message: string }>() {
+  constructor() {
+    super({ message: "Invalid duration format provided" })
+  }
+}

+export class AssertConditionFailedError extends Tagged("AssertConditionFailedError")<{
+  message: string
+  condition: string
+}>() {}


	export class UnauthenticatedError extends Tagged("AuthenticationError")() {}


	export class UnauthorizedError extends Tagged("AuthorizationError")<{ userId: string }>() {}

+export class SendEmailError extends Tagged("SendEmailError")<{
+  emails: string[]
+  subject: string
+  from?: string
+  text: string
+}>() {}

Conversation

adelrodriguez commented Feb 19, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

coderabbitai bot commented Feb 19, 2026

Review skipped

Uh oh!

adelrodriguez commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

adelrodriguez commented Feb 19, 2026 •

edited by greptile-apps bot

Loading

adelrodriguez commented Feb 19, 2026 •

edited

Loading