Implement pre-extracted sources snapshot system for rcclx with self-contained build #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@srinathb-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91904438. |
srinathb-meta
added a commit
to srinathb-meta/torchcomms
that referenced
this pull request
Feb 1, 2026
…ontained build (meta-pytorch#520) Summary: Pull Request resolved: meta-pytorch#520 This diff implements a pre-extracted sources snapshot system for rcclx that eliminates ABI mismatch issues by building rcclx from source at build time instead of using pre-compiled bundled dependencies. The key change replaces the previous Manifold-based snapshot approach with a simpler file-based approach where rcclx sources from specific commits are extracted and committed to the repository under comms/rcclx/snapshots/{stable,last-stable}/. The create_snapshot.py script uses sl archive to extract sources from specified commits, then automatically fixes absolute Buck load paths (e.g., fbcode//comms/rcclx/develop:def_build.bzl) to point within the snapshot directory, ensuring each snapshot is self-contained. Additionally, the script adds compiler flags (-Wno-deprecated-this-capture, -Wno-unused-exception-parameter) to suppress warnings that weren't errors when the snapshot code was written but are now treated as errors with current compiler settings. The BUCK file defines rcclx-stable and rcclx-last-stable aliases that point to the snapshot's rcclx-dev target, allowing downstream consumers to build against stable rcclx versions with guaranteed ABI compatibility. Obsolete Manifold-related scripts have been removed as they are no longer needed. Reviewed By: dmwu Differential Revision: D91904438
srinathb-meta
force-pushed
the
export-D91904438
branch
from
851e810 to
6fa5485
Compare
srinathb-meta
added a commit
to srinathb-meta/torchcomms
that referenced
this pull request
Feb 1, 2026
…ontained build (meta-pytorch#520) Summary: Pull Request resolved: meta-pytorch#520 This diff implements a pre-extracted sources snapshot system for rcclx that eliminates ABI mismatch issues by building rcclx from source at build time instead of using pre-compiled bundled dependencies. The key change replaces the previous Manifold-based snapshot approach with a simpler file-based approach where rcclx sources from specific commits are extracted and committed to the repository under comms/rcclx/snapshots/{stable,last-stable}/. The create_snapshot.py script uses sl archive to extract sources from specified commits, then automatically fixes absolute Buck load paths (e.g., fbcode//comms/rcclx/develop:def_build.bzl) to point within the snapshot directory, ensuring each snapshot is self-contained. Additionally, the script adds compiler flags (-Wno-deprecated-this-capture, -Wno-unused-exception-parameter) to suppress warnings that weren't errors when the snapshot code was written but are now treated as errors with current compiler settings. The BUCK file defines rcclx-stable and rcclx-last-stable aliases that point to the snapshot's rcclx-dev target, allowing downstream consumers to build against stable rcclx versions with guaranteed ABI compatibility. Obsolete Manifold-related scripts have been removed as they are no longer needed. Reviewed By: dmwu Differential Revision: D91904438
srinathb-meta
force-pushed
the
export-D91904438
branch
from
6fa5485 to
4ad1ae5
Compare
…ontained build
Summary: This diff implements a pre-extracted sources snapshot system for rcclx that eliminates ABI mismatch issues by building rcclx from source at build time instead of using pre-compiled bundled dependencies. The key change replaces the previous Manifold-based snapshot approach with a simpler file-based approach where rcclx sources from specific commits are extracted and committed to the repository under comms/rcclx/snapshots/{stable,last-stable}/. The create_snapshot.py script uses sl archive to extract sources from specified commits, then automatically fixes absolute Buck load paths (e.g., fbcode//comms/rcclx/develop:def_build.bzl) to point within the snapshot directory, ensuring each snapshot is self-contained. Additionally, the script adds compiler flags (-Wno-deprecated-this-capture, -Wno-unused-exception-parameter) to suppress warnings that weren't errors when the snapshot code was written but are now treated as errors with current compiler settings. The BUCK file defines rcclx-stable and rcclx-last-stable aliases that point to the snapshot's rcclx-dev target, allowing downstream consumers to build against stable rcclx versions with guaranteed ABI compatibility. Obsolete Manifold-related scripts have been removed as they are no longer needed.
Reviewed By: dmwu
Differential Revision: D91904438
srinathb-meta
force-pushed
the
export-D91904438
branch
from
4ad1ae5 to
392c88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff implements a pre-extracted sources snapshot system for rcclx that eliminates ABI mismatch issues by building rcclx from source at build time instead of using pre-compiled bundled dependencies. The key change replaces the previous Manifold-based snapshot approach with a simpler file-based approach where rcclx sources from specific commits are extracted and committed to the repository under comms/rcclx/snapshots/{stable,last-stable}/. The create_snapshot.py script uses sl archive to extract sources from specified commits, then automatically fixes absolute Buck load paths (e.g., fbcode//comms/rcclx/develop:def_build.bzl) to point within the snapshot directory, ensuring each snapshot is self-contained. Additionally, the script adds compiler flags (-Wno-deprecated-this-capture, -Wno-unused-exception-parameter) to suppress warnings that weren't errors when the snapshot code was written but are now treated as errors with current compiler settings. The BUCK file defines rcclx-stable and rcclx-last-stable aliases that point to the snapshot's rcclx-dev target, allowing downstream consumers to build against stable rcclx versions with guaranteed ABI compatibility. Obsolete Manifold-related scripts have been removed as they are no longer needed.
Reviewed By: dmwu
Differential Revision: D91904438