enable single-dim sharding strategies#327
Open
pianpwk wants to merge 1 commit intometa-pytorch:mainfrom
Open
Conversation
meta-cla
bot
added
the
CLA Signed
pianpwk
changed the title
pianpwk
force-pushed
the
pianpwk/single_dim_strats
branch
from
f0df555 to
fad6c47
Compare
Upstream DTensor is migrating ops from register_op_strategy (op_strategy_funcs) to register_single_dim_strategy (op_single_dim_strategy_funcs). This broke autoparallel for ops like aten.view_as_complex that have been migrated, since get_op_strategy only checked op_strategy_funcs. Add _try_single_dim_strategy which calls the single-dim strategy function directly, resolves _ShardingPlaceholder -> Shard (upstream's placeholder expansion relies on runtime input placements, but autoparallel explores all placements), and expands to full mesh via expand_to_full_mesh_op_strategy. Also fixes black formatting in _try_decomp_sharding. Authored with Claude.
pianpwk
force-pushed
the
pianpwk/single_dim_strats
branch
from
fad6c47 to
057c127
Compare
pianpwk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix the llama3 view_as_complex CI issue. As more sharding strategies migrate to single-dim rules, autoparallel will break as it doesn't query single-dim strategies yet, e.g. pytorch/pytorch#173935