Skip to content

Fix torchtitan CI after TOML-to-Python config refactor#325

Merged
xmfan merged 1 commit intomainfrom
xmfan/stack/26
Feb 25, 2026
Merged

Fix torchtitan CI after TOML-to-Python config refactor#325
xmfan merged 1 commit intomainfrom
xmfan/stack/26

Conversation

@xmfan
Copy link
Member

@xmfan xmfan commented Feb 24, 2026

Stacked PRs:


Fix torchtitan CI after TOML-to-Python config refactor

Torchtitan merged a BC-breaking config system refactor (pytorch/torchtitan#2386)
that replaced TOML configs with Python dataclass configs and changed the
CLI from CONFIG_FILE + --model.name to --module + --config.

Updates the CI commands accordingly. Also fixes a runtime crash where
aliased buffers (registered for user-facing API compat by #321) were
being passed to the compiled graph, which only expects the canonical
(deduplicated) set. The deepseek_v3 test is commented out as it's also
disabled in torchtitan's own CI.

Authored with Claude.

xmfan added a commit that referenced this pull request Feb 24, 2026
Torchtitan merged a BC-breaking config system refactor (pytorch/torchtitan#2386)
that replaced TOML configs with Python dataclass configs and changed the
CLI from CONFIG_FILE + --model.name to --module + --config.

Updates the CI commands accordingly. Also fixes a runtime crash where
aliased buffers (registered for user-facing API compat by #321) were
being passed to the compiled graph, which only expects the canonical
(deduplicated) set. The deepseek_v3 test is commented out as it's also
disabled in torchtitan's own CI.

Authored with Claude.

stack-info: PR: #325, branch: xmfan/stack/26
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 24, 2026
xmfan added a commit that referenced this pull request Feb 25, 2026
Torchtitan merged a BC-breaking config system refactor (pytorch/torchtitan#2386)
that replaced TOML configs with Python dataclass configs and changed the
CLI from CONFIG_FILE + --model.name to --module + --config.

Updates the CI commands accordingly. Also fixes a runtime crash where
aliased buffers (registered for user-facing API compat by #321) were
being passed to the compiled graph, which only expects the canonical
(deduplicated) set. The deepseek_v3 test is commented out as it's also
disabled in torchtitan's own CI.

Authored with Claude.

stack-info: PR: #325, branch: xmfan/stack/26
Torchtitan merged a BC-breaking config system refactor (pytorch/torchtitan#2386)
that replaced TOML configs with Python dataclass configs and changed the
CLI from CONFIG_FILE + --model.name to --module + --config.

Updates the CI commands accordingly. Also fixes a runtime crash where
aliased buffers (registered for user-facing API compat by #321) were
being passed to the compiled graph, which only expects the canonical
(deduplicated) set. The deepseek_v3 test is commented out as it's also
disabled in torchtitan's own CI.

Authored with Claude.

stack-info: PR: #325, branch: xmfan/stack/26
@xmfan xmfan merged commit 7933d8a into main Feb 25, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant