[overlap] Overlap simulation on 1d, 2d variants of llama3, DSv3#319
Open
IvanKobzarev wants to merge 1 commit intomainfrom
Open
[overlap] Overlap simulation on 1d, 2d variants of llama3, DSv3#319IvanKobzarev wants to merge 1 commit intomainfrom
IvanKobzarev wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
autoparallel-bot
force-pushed
the
overlap_simulator
branch
from
d568766 to
d97cb00
Compare
fmassa
reviewed
Feb 18, 2026
Comment on lines
+285
to
+286
| while is_wait_tensor(comm_node): | ||
| comm_node = comm_node.args[0] |
Contributor
There was a problem hiding this comment.
Can you explain a bit more what is going on here? Can there be multiple redundant wait_tensor calls in the graph>
fmassa
reviewed
Feb 18, 2026
| "inputs": [get_repr(arg) for arg in node.args], | ||
| } | ||
|
|
||
| if dur > 0.0: |
Contributor
There was a problem hiding this comment.
When can this happen, is it to remove wait_tensor and getitem operators?
I have found it nice to have a 1:1 mapping between the graph and the trace, is the added launch_overhead biasing the visualization?
fmassa
approved these changes
Feb 18, 2026
Contributor
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Let's remove the dur == 0 condition, otherwise good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --save-traces to generate perfetto trace files