Draft
Conversation
For now assumes it's balanced
facebook-github-bot
added
the
CLA Signed
wconstab
approved these changes
Jun 16, 2025
wconstab
reviewed
Jun 16, 2025
Contributor
wconstab
left a comment
wconstab
left a comment
There was a problem hiding this comment.
kinda curious, do you have the solution handy for this?
Everything seems to be working as expected!
ezyang
approved these changes
Sep 27, 2025
fmassa
added a commit
that referenced
this pull request
Oct 1, 2025
Very slow, need to try Sinkhorn-Knopp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now assumes it's balanced.
Note that AutoParallel doesn't work in this case (sort operator not implemented, and maybe other things as well involving the indexing)
Note: For now I'm picking a single expert per token, but that can be changed (maybe at the expense of replicating the tokens, which needs to be assessed to see if the memory increase is reasonable)