Conversation
cbuto
reviewed
Aug 4, 2023
cbuto
left a comment
cbuto
left a comment
There was a problem hiding this comment.
looks like there's a few other failures with some of the dep updates
| @@ -7,77 +7,80 @@ require ( | |||
| github.com/ghodss/yaml v1.0.1-0.20220118164431-d8423dcdf344 | |||
There was a problem hiding this comment.
side note: should we update the module name to be?
module github.com/mesosphere/kubefed
Author
There was a problem hiding this comment.
i see no harm in doing that (apart from all the refactoring thats needed in kommander repo) but also, there is no real upside (aesthetics aside). we want to get rid of kubefed eventually anyway so maybe this is fine 🙈
takirala
force-pushed
the
tga/bump-deps
branch
2 times, most recently
from
f91de42 to
93e86c2
Compare
takirala
changed the title
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Author
|
I bumped controller runtime in #17 and this change is no longer urgent, i am shelving this PR for future use if/when we have the need to bump ginkgo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumps ginkgo to v2 and also uses 1.27.x for kind node images Depends on #17
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: