-
Notifications
You must be signed in to change notification settings - Fork 1
Add Docker build workflow on release
#170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Oh perhaps we should also customise the |
| # starting from firedrake-parmmg-base, build firedrake-parmmg image | ||
| # which includes Animate, Movement, Goalie, and Thetis packages | ||
| dockerfile-path: 'docker/Dockerfile.firedrake-parmmg' | ||
| docker-image-tag: 'ghcr.io/mesh-adaptation/firedrake-parmmg-release:latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, perhaps it makes more sense to have a release tag rather than a separate image? (And similarly elsewhere)
| docker-image-tag: 'ghcr.io/mesh-adaptation/firedrake-parmmg-release:latest' | |
| docker-image-tag: 'ghcr.io/mesh-adaptation/firedrake-parmmg:release' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d0907b2.
|
@stephankramer do you have any idea what might be going wrong in the |
|
So I think the problem is that when building the base container from firedrake's Dockerfile.vanilla, if we're building firedrake release (by passing that branch as a build argument), the Dockerfile.vanilla itself also needs to come from the release branch of firedrake (because the build sequence may have changed between release and main). I renamed the firedrake-branch input to dockerfile-branch input, so that we can default it to the github ref associated with the triggering action (e.g. the PR branch, or main after the merge) for the Dockerfiles that are in this docs/ repo. The same input is also still passed as a build argument to specify which firedrake branch to build, but that's only picked up anyway if the actual base container is being build from firedrake's Dockerfile.vanilla, and safely ignored when building the subsequent ones from the Dockerfiles in docs/. |
Ah okay, that makes sense. Thanks for looking into this! I'll come back to my other unresolved comments above. |
Done in a9b6d6d. |
|
@stephankramer please could you review this? I think it's ready now. |
|
Oh sorry, quoting myself from above:
having another at the changes in the PR - I realize this is no longer true :-( So we probably need two separate inputs to the reusable build worflow:
|
Closes #156.
This PR sets up a separate workflow for building and pushing a Docker build for the
releasebranch. It passes--build-arg BRANCH=releaseto the Firedrake Docker build. It's triggered on updates to the workflow and on a monthly basis.