Skip to content

Feat/grpc#8

Open
markovejnovic wants to merge 2 commits intomainfrom
feat/grpc
Open

Feat/grpc#8
markovejnovic wants to merge 2 commits intomainfrom
feat/grpc

Conversation

@markovejnovic
Copy link
Collaborator

No description provided.

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Feb 17, 2026

Mesa Description

This PR introduces the foundation for a new gRPC-based data plane for the Version Control System (VCS). By leveraging Protocol Buffers, it establishes a strongly-typed, high-performance API for all core VCS operations.

Key Changes:

  • gRPC Service Definition (vcs.proto):

    • Defines the core API contract for the VCS data plane.
    • Establishes three primary services:
      • ControlService: Write operations (e.g., creating commits, branches).
      • DataService: Read-only operations (e.g., fetching objects).
      • BlobTransferService: Optimized for large object transfers.
  • Build System Integration:

    • Adds tonic, prost, and tokio as core dependencies to support the gRPC stack.
    • The build.rs script now automatically compiles the .proto files into Rust client code during the build process.
  • CI/CD Automation:

    • A new GitHub Actions workflow (accept_proto.yml) is added to automate the process of updating and validating protocol buffer definitions, ensuring consistency and correctness.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 0141cd1...7b17121

Analysis

  1. Build script requires proto sources at compile time, but these sources are not versioned, which will break downstream builds.
  2. gRPC runtime dependencies are added unconditionally without feature gates, forcing all consumers to inherit a heavy async stack before any gRPC API surface exists.
  3. The PR leaves the application-layer implementation incomplete - needs either committed proto definitions with generated bindings or feature-gated build steps.
  4. Current implementation will prevent the existing REST client from building until the gRPC components are fully implemented.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

0 files reviewed | 1 comments | Edit Agent SettingsRead Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments