Skip to content

Prefetching (non-slop)#40

Open
markovejnovic wants to merge 28 commits intomainfrom
marko/mes-696-lookup-pre-fetch-post-readdir-2
Open

Prefetching (non-slop)#40
markovejnovic wants to merge 28 commits intomainfrom
marko/mes-696-lookup-pre-fetch-post-readdir-2

Conversation

@markovejnovic
Copy link
Collaborator

No description provided.

@blacksmith-sh

This comment has been minimized.

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Feb 18, 2026

Mesa Description

This PR introduces a new asynchronous, multi-layered filesystem caching layer designed to improve performance by prefetching and caching filesystem metadata and data.

The core of this change is AsyncFs, a new asynchronous filesystem cache that manages concurrent access to inodes and file data. It is supported by several new components:

  • DCache: A directory entry cache to speed up lookups and readdir operations.
  • FutureBackedCache: A generic cache to deduplicate concurrent asynchronous operations, ensuring that data is fetched only once.
  • DropWard: A resource management system that handles automatic cleanup and eviction of cached resources, which is critical for managing the lifecycle of cached objects.

Together, these components create a robust and performant caching abstraction over the filesystem, laying the groundwork for significant I/O performance improvements.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of e2d3738...b4fa0dc

Analysis

  1. Incomplete architecture for new asynchronous filesystem caching - the AsyncFs component lacks critical interfaces for table population and write-through to the directory cache, making these data structures currently unusable.

  2. Background task orchestration framework is added but not connected to the rest of the system, leaving the foundational infrastructure without clear integration paths.

  3. Significant regression in telemetry configuration - removal of Trc::with_telemetry and hard-coding of OTLP exporter means application-level telemetry settings are now ignored.

  4. The PR attempts to introduce multiple significant architectural changes simultaneously (async filesystem caching, background tasks, telemetry rework) without complete implementation paths for each.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

0 files reviewed | 9 comments | Edit Agent SettingsRead Docs

@markovejnovic markovejnovic force-pushed the marko/mes-696-lookup-pre-fetch-post-readdir-2 branch 2 times, most recently from 4bb43c2 to 6d0510c Compare February 19, 2026 00:13
@markovejnovic markovejnovic force-pushed the marko/mes-696-lookup-pre-fetch-post-readdir-2 branch from 176d4d3 to c8b0bd4 Compare February 19, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments