Open
Conversation
… EFCore.SingleStore/Extensions
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the SingleStore EF Core provider from EF Core 8 to EF Core 9. This is a major version upgrade that includes updating the .NET SDK to 9.0, updating all EF Core package dependencies to 9.0.0, and adapting to breaking changes in the EF Core 9 API surface.
Changes:
- Updated .NET SDK from 8.0 to 9.0 and target framework for tests from net8.0 to net9.0
- Updated EF Core dependencies from 8.0.13 to 9.0.0 and SingleStoreConnector from 1.2.0 to 1.3.0
- Converted synchronous test methods to async patterns throughout the test suite
- Adapted to EF Core 9 API changes including query compilation context, parameter processors, and expression handling
- Implemented new EF Core 9 features like migration database locking and precompiled query infrastructure
- Fixed various bugs in regex patterns, variable naming, and expression handling
- Added new test attributes and query translation methods
Reviewed changes
Copilot reviewed 148 out of 212 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| global.json, Version.props, Directory.Packages.props | Updated SDK version to 9.0.100, package versions to EF Core 9.0.0 |
| Multiple test files | Converted test fixtures to IAsyncLifetime, changed sync methods to async |
| Query/Internal/*.cs | Updated query compilation context and parameter processor signatures for EF Core 9 |
| Query/ExpressionVisitors/*.cs | Added bitwiseexpression visitor, updated expression handling |
| Migrations/Internal/*.cs | Implemented migration database locking, updated constructor signatures |
| Storage/Internal/*.cs | Fixed connection cloning to mark as owned |
| Infrastructure/*.cs | Added DefaultUtf8 collation properties, updated server version support |
| Extensions/*.cs | Added JsonOverlaps function, ComplexTypeProperty extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.