Skip to content

Conversation

@txgk
Copy link
Contributor

@txgk txgk commented Oct 15, 2025

When I compile the library with warnings enabled, I get some unpleasant output during the build stage:

Source/geom.c: In functiontesedgeIntersect’:
Source/geom.c:220:50: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  220 |         if( ! VertLeq( o1, d1 )) { Swap( o1, d1 ); }
      |                                                  ^
Source/geom.c:221:50: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  221 |         if( ! VertLeq( o2, d2 )) { Swap( o2, d2 ); }
      |                                                  ^
Source/geom.c:222:50: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  222 |         if( ! VertLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); }
      |                                                  ^
Source/geom.c:222:66: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  222 |         if( ! VertLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); }
      |                                                                  ^
Source/geom.c:243:51: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  243 |         if( ! TransLeq( o1, d1 )) { Swap( o1, d1 ); }
      |                                                   ^
Source/geom.c:244:51: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  244 |         if( ! TransLeq( o2, d2 )) { Swap( o2, d2 ); }
      |                                                   ^
Source/geom.c:245:51: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  245 |         if( ! TransLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); }
      |                                                   ^
Source/geom.c:245:67: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  245 |         if( ! TransLeq( o1, o2 )) { Swap( o1, o2 ); Swap( d1, d2 ); }
      |                                                                   ^
Source/mesh.c: In functiontessMeshFlipEdge’:
Source/mesh.c:751:34: warning: unused parametermesh’ [-Wunused-parameter]
  751 | void tessMeshFlipEdge( TESSmesh *mesh, TESShalfEdge *edge )
      |                        ~~~~~~~~~~^~~~
Source/priorityq.c: In functionpqInit’:
Source/priorityq.c:385:45: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  385 |                                 Swap( i, j );
      |                                             ^
Source/priorityq.c:387:37: warning: suggest braces around empty body in anelsestatement [-Wempty-body]
  387 |                         Swap( i, j ); /* Undo last swap */
      |

I provide a little patch to fix that if you're interested, otherwise never mind ;)

@sfreilich
Copy link
Collaborator

Looks good, thanks!

@sfreilich sfreilich merged commit 8dbd648 into memononen:master Oct 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants