Skip to content

fix the bug(#24) on resize() #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Laeyoung wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix the bug(#24) on resize() #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/ImageHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public extension UIImage {

- Returns A new image
*/
func resize(toSize: CGSize, contentMode: UIImageContentMode = .scaleToFill) -> UIImage? {
func resize(size: CGSize, contentMode: UIImageContentMode = .scaleToFill) -> UIImage? {
let horizontalRatio = size.width / self.size.width;
let verticalRatio = size.height / self.size.height;
var ratio: CGFloat!
Expand All @@ -349,7 +349,7 @@ public extension UIImage {
ratio = min(horizontalRatio, verticalRatio)
}

let rect = CGRect(x: 0, y: 0, width: size.width * ratio, height: size.height * ratio)
let rect = CGRect(x: 0, y: 0, width: size.width, height: size.height)

// Fix for a colorspace / transparency issue that affects some types of
// images. See here: http://vocaro.com/trevor/blog/2009/10/12/resize-a-uiimage-the-right-way/comment-page-2/#comment-39951
Expand Down