Open
Conversation
Member
|
PR里包含了答案，不合适merge。 |
Author
|
Emmmm...ok. But whether the pull request can be merged after the final deadlines? |
|
Cool! I love pytorch. |
Member
|
@PaParaZz1 We'd love to include your py-torch version. Before we can accept, can you remove the markdowns (to avoid duplication) and the answers? |
Author
|
@zsc Thank you!!! You mean that I need to only prepare a baseline version? I need a bit of time to modify my code. |
Author
|
@zsc I have cleaned the code and removed redundant files and answers. You can review the code and merge it then. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the Pytorch version's homework1. If you review the code and think it good enough, I hope it can be merged into origin repo and utilized by other people.