Regex fix that failed to load cookie from store.#143
Open
StotoV wants to merge 1 commit intomebjas:masterfrom
Open
Regex fix that failed to load cookie from store.#143StotoV wants to merge 1 commit intomebjas:masterfrom
StotoV wants to merge 1 commit intomebjas:masterfrom
Conversation
The regex did not take into account that spaces around the cookie entries are possible. This fix remedies that by expanding the regex rule in the javascript. Further documentation: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie
|
I was working with this library today and I found your fix, but that fix is actually incorrect as well, the space is accounted the problem is the use of `` strings on js, instead of should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex did not take into account that spaces around the cookie entries are possible.
This fix remedies that by expanding the regex rule in the javascript.
Further documentation: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie