Open
Conversation
- CLI build used "buildCli", CLI plugins used "buildPluginsCLI" - normalized to "...Cli" for both. Signed-off-by: FeRD (Frank Dana) <ferdnyc@gmail.com>
Contributor
Author
|
(Oh, yes, and as further precedent, there was already this:) avidemux2/bootStrapCrossMingwQt5_mxe.sh Lines 407 to 410 in 6063658 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrap scripts were using "buildCli" as the name of the CLI builddir, but then the CLI plugins were built in a directory named "buildPluginsCLI", a difference in casing that just seems unnecessarily confusing.
I normalized them to "buildCli" and "buildPluginsCli", though I'd be happy to go the other way ("CLI" for both) if preferred.