Open
Conversation
github-actions
bot
added
data:html
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
requested changes
Feb 18, 2026
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "31" | ||
| "version_added": "75" |
Contributor
There was a problem hiding this comment.
Shouldn't we at least mark it as partial before the hiding behavior was supported, assuming it was already parsed and taken into consideration for its intended use case, Content-Security-Policy validation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I created this structure originally, but I don't like it. The implementation of the nonce attribute is complete when browsers implement it fully, so that also means nonce hiding.
We can argue if we want version ranges and partial support for Firefox 31-75 and Safari 15.4-15.5 when there was no nonce hiding, but maybe that's not too interesting anymore. Happy to add it if you want me to, though.
Test results and supporting details
Data remains the same, just no sub feature anymore.
Collector can more easily test this entry
Related issues
None open, I think.