Firefox still has NodeIterator.detach()#28935
Merged
Conversation
github-actions
bot
added
data:api
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
changed the title
NodeIterator.detach()NodeIterator.detach()
github-actions
bot
added
size:s
caugner
force-pushed
the
20829-NodeIterator-detach-in-Firefox
branch
from
2cea370 to
642ee30
Compare
ddbeck
approved these changes
Feb 3, 2026
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I think this is fine as written, though it would be nice to indicate this is intended, specified behavior. Something like this?
Since Browser vX, this method does nothing, as specified. See bug …
If you make those changes, feel free to merge at your discretion or request re-review. Thank you!
Contributor
Author
I assume you would expect the same changes for |
Contributor
|
@caugner yes, that's correct. |
It might be correct to set `"mirror"`, but this would also affect the parent and sibling features.
caugner
force-pushed
the
20829-NodeIterator-detach-in-Firefox
branch
from
e4d7ae5 to
29745db
Compare
github-actions
bot
added
size:m
Contributor
Author
|
Done in 29745db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Firefox statement for
NodeIterator.detach(), indicating that this is still supported.Test results and supporting details
Verified with collector test, see this comment.
Related issues
Fixes #20829.