Open
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
ddbeck
requested changes
Feb 11, 2026
| { | ||
| "version_added": "57" | ||
| "version_added": "57", | ||
| "notes": "Before Firefox 139, `getSelection().toString()` returns an empty string on form elements. See [bug 85686](https://bugzil.la/85686)." |
Contributor
There was a problem hiding this comment.
This ought to be a note on api.Selection.toString.
| "partial_implementation": true, | ||
| "notes": "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects." | ||
| "notes": [ | ||
| "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects.", |
Contributor
There was a problem hiding this comment.
What does "supported" mean? Exposed? Returns a Selection object? Something else?
| "notes": "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects." | ||
| "notes": [ | ||
| "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects.", | ||
| "`getSelection().toString()` returns an empty string on form elements. See [bug 85686](https://bugzil.la/85686)." |
Contributor
There was a problem hiding this comment.
This ought to be a note on api.Selection.toString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Firefox notes for
Document.getSelection()mentioning a limitation before Firefox 139.Test results and supporting details
See issue below.
Related issues
Fixes #21697.