Modernize Python package configuration to eliminate build warnings#3
Modernize Python package configuration to eliminate build warnings#3Copilot wants to merge 2 commits intocopilot/update-file-handling-systemfrom
Conversation
Co-authored-by: mdellison90-stack <230609064+mdellison90-stack@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696b3aa7cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from setuptools import setup | ||
|
|
||
| setup( | ||
| name='bbchop', | ||
| version='0.1.0', | ||
| description='Bisection algorithm which works on intermittent bugs', | ||
| long_description=long_description, | ||
| long_description_content_type='text/plain', | ||
| author='Ealdwulf Wuffinga', | ||
| license='GPL-2.0-or-later', | ||
| url='https://github.com/mdellison90-stack/bbchop', | ||
|
|
||
| # Package discovery | ||
| package_dir={'': 'BBChop/source'}, |
There was a problem hiding this comment.
Preserve metadata for legacy setup.py installs
When users install on Python 2.6/2.7 (still listed as supported) or run python setup.py install / pip install --no-use-pep517, setuptools does not use the PEP 621 metadata in pyproject.toml. With setup() now only receiving package discovery args, those legacy installs will miss required metadata (name/version/author/extras), which can result in an UNKNOWN distribution and makes the fast extra unavailable in those environments. Consider keeping minimal metadata in setup.py (or a setup.cfg) to preserve legacy install behavior.
Useful? React with 👍 / 👎.
Build process generated deprecation warnings from setuptools due to outdated packaging configuration patterns.
Changes
licensefield from deprecated TOML table to SPDX string ("GPL-2.0-or-later"), removed obsolete license classifierBuild now completes cleanly without setuptools deprecation warnings while maintaining identical package functionality.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.