Skip to content

Modernize Python package configuration to eliminate build warnings#3

Open
Copilot wants to merge 2 commits intocopilot/update-file-handling-systemfrom
copilot/update-test-action-workflow
Open

Modernize Python package configuration to eliminate build warnings#3
Copilot wants to merge 2 commits intocopilot/update-file-handling-systemfrom
copilot/update-test-action-workflow

Conversation

Copy link

Copilot AI commented Jan 25, 2026

Build process generated deprecation warnings from setuptools due to outdated packaging configuration patterns.

Changes

  • pyproject.toml: Updated license field from deprecated TOML table to SPDX string ("GPL-2.0-or-later"), removed obsolete license classifier
  • setup.py: Removed duplicate metadata already declared in pyproject.toml (name, version, license, classifiers, etc.), keeping only build-specific configuration (package_dir, py_modules, scripts)

Build now completes cleanly without setuptools deprecation warnings while maintaining identical package functionality.

Original prompt

Reference: https://github.com/mdellison90-stack/bbchop/actions/runs/21330234778/job/61393856519


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mdellison90-stack <230609064+mdellison90-stack@users.noreply.github.com>
Copilot AI changed the title [WIP] Update test action in workflow Modernize Python package configuration to eliminate build warnings Jan 25, 2026
@mdellison90-stack mdellison90-stack marked this pull request as ready for review January 25, 2026 11:00
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 696b3aa7cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +6 to 10
from setuptools import setup

setup(
name='bbchop',
version='0.1.0',
description='Bisection algorithm which works on intermittent bugs',
long_description=long_description,
long_description_content_type='text/plain',
author='Ealdwulf Wuffinga',
license='GPL-2.0-or-later',
url='https://github.com/mdellison90-stack/bbchop',

# Package discovery
package_dir={'': 'BBChop/source'},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve metadata for legacy setup.py installs

When users install on Python 2.6/2.7 (still listed as supported) or run python setup.py install / pip install --no-use-pep517, setuptools does not use the PEP 621 metadata in pyproject.toml. With setup() now only receiving package discovery args, those legacy installs will miss required metadata (name/version/author/extras), which can result in an UNKNOWN distribution and makes the fast extra unavailable in those environments. Consider keeping minimal metadata in setup.py (or a setup.cfg) to preserve legacy install behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants