Skip to content

Conversation

@mcmah309
Copy link
Owner

@mcmah309 mcmah309 commented Dec 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 03:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the error_set_part! macro to enable distributed error set definitions across multiple files. Instead of defining all errors in a single location, developers can now define error parts in different modules, which are automatically combined into a single error_set! macro at build time via the combine_error_set_parts() function.

Key changes:

  • Added new error_set_part! macro that generates use statements for error types
  • Implemented build-time combining of error_set_part definitions into a centralized error_set.rs file
  • Added combine_parts feature with the ignore crate dependency for file system traversal
  • Reorganized examples into an examples/ directory structure

Reviewed changes

Copilot reviewed 13 out of 18 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
error_set_impl/src/lib.rs Adds new error_set_part! proc macro that extracts error names and generates use statements
error_set/src/lib.rs Exports combine_error_set_parts function when combine_parts feature is enabled
error_set/src/combine_parts.rs Implements file scanning, parsing, and combining logic to merge error_set_part definitions
error_set/Cargo.toml Adds ignore dependency and combine_parts feature (set as default)
examples/error_set_part/ Complete example demonstrating distributed error definitions across multiple files
examples/test_no_std/ Moved from root to examples directory, demonstrates no_std compatibility
Cargo.toml Updates workspace members to include new examples and exclude test_no_std
.github/workflows/ci.yml Updates CI path to reflect test_no_std relocation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mcmah309 mcmah309 merged commit e749b3b into master Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants