⚡ Async Config Saving for ItemManager

modules/ItemManager/pom.xml

@@ -70,5 +70,29 @@
             <version>1.12.2-R0.1-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.13.2</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-inline</artifactId>
+            <version>5.2.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>net.bytebuddy</groupId>
+            <artifactId>byte-buddy</artifactId>
+            <version>1.14.17</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>net.bytebuddy</groupId>
+            <artifactId>byte-buddy-agent</artifactId>
+            <version>1.14.17</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 </project>

modules/ItemManager/src/main/java/com/mcatk/itemmanager/ItemManager.java

@@ -1,17 +1,28 @@
 package com.mcatk.itemmanager;
 
 import org.bukkit.Bukkit;
+import org.bukkit.configuration.file.YamlConfiguration;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.plugin.java.JavaPlugin;
 
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.logging.Level;
+
 public final class ItemManager extends JavaPlugin {
 
     private static ItemManager plugin;
     private static ItemSort itemSort;
+    private ExecutorService ioExecutor;
 
     @Override
     public void onEnable() {
         plugin = this;
+        ioExecutor = Executors.newSingleThreadExecutor();
         saveConfig();
         itemSort = new ItemSort();
         regCommand();
@@ -20,6 +31,9 @@ public void onEnable() {
 
     @Override
     public void onDisable() {
+        if (ioExecutor != null) {
+            ioExecutor.shutdown();
+        }
     }
 
     public static ItemManager getPlugin() {
@@ -46,4 +60,27 @@ public static ItemStack getItem(String sortId, String itemId) {
     public static void addItem(String sortId, String itemId, ItemStack itemStack) {
         itemSort.addItem(sortId, itemId, itemStack);
     }
+
+    public void setIoExecutor(ExecutorService ioExecutor) {
+        this.ioExecutor = ioExecutor;
+    }
+
+    public void saveConfigAsync() {
+        if (!isEnabled()) {
+            return;
+        }
+        if (getConfig() instanceof YamlConfiguration) {
+            final String data = ((YamlConfiguration) getConfig()).saveToString();
+            final File file = new File(getDataFolder(), "config.yml");
+            ioExecutor.submit(() -> {
+                try {
+                    Files.write(file.toPath(), data.getBytes(StandardCharsets.UTF_8));
+                } catch (IOException ex) {
+                    getLogger().log(Level.SEVERE, "Could not save config to " + file, ex);
+                }
+            });
+        } else {
+            saveConfig();
+        }
+    }
 }

modules/ItemManager/src/main/java/com/mcatk/itemmanager/ItemSort.java

@@ -28,7 +28,7 @@ public void addItem(String id1, String id2, ItemStack itemStack) {
         }
         itemsHashMap.get(id1).getItemStackHashMap().put(id2, itemStack);
         ItemManager.getPlugin().getConfig().set(id1 + "." + id2, itemStack);
-        ItemManager.getPlugin().saveConfig();
+        ItemManager.getPlugin().saveConfigAsync();
     }
 
     public ItemStack getItem(String id1, String id2) {

modules/ItemManager/src/test/java/com/mcatk/itemmanager/ItemSortBenchmarkTest.java

@@ -0,0 +1,75 @@
+package com.mcatk.itemmanager;
+
+import org.bukkit.configuration.file.YamlConfiguration;
+import org.bukkit.inventory.ItemStack;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.stubbing.Answer;
+
+import java.lang.reflect.Field;
+import java.util.HashSet;
+import java.util.logging.Logger;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.*;
+
+public class ItemSortBenchmarkTest {
+
+    private ItemManager itemManager;
+    private YamlConfiguration config;
+    private ItemSort itemSort;
+
+    @Before
+    public void setUp() throws Exception {
+        itemManager = mock(ItemManager.class);
+        config = mock(YamlConfiguration.class);
+        Logger logger = mock(Logger.class);
+
+        // Set static plugin field
+        Field pluginField = ItemManager.class.getDeclaredField("plugin");
+        pluginField.setAccessible(true);
+        pluginField.set(null, itemManager);
+
+        when(itemManager.getConfig()).thenReturn(config);
+        when(itemManager.getLogger()).thenReturn(logger);
+        when(config.getKeys(false)).thenReturn(new HashSet<>());
+
+        // Mock saveConfig to simulate I/O delay
+        doAnswer((Answer<Void>) invocation -> {
+            try {
+                Thread.sleep(10); // Simulate 10ms disk I/O
+            } catch (InterruptedException e) {
+                e.printStackTrace();
+            }
+            return null;
+        }).when(itemManager).saveConfig();
+
+        itemSort = new ItemSort();
+    }
+
+    @Test
+    public void benchmarkAddItem() {
+        long startTime = System.currentTimeMillis();
+        int iterations = 50;
+
+        for (int i = 0; i < iterations; i++) {
+            itemSort.addItem("sort1", "item" + i, mock(ItemStack.class));
+        }
+
+        long endTime = System.currentTimeMillis();
+        long duration = endTime - startTime;
+
+        System.out.println("Time taken for " + iterations + " adds: " + duration + "ms");
+
+        // Now it should be fast (< 100ms) because saveConfigAsync (mocked) does nothing
+        assertTrue("Should be fast (< 100ms) with async saving", duration < 100);
+
+        // Verify saveConfigAsync was called 50 times
+        verify(itemManager, times(iterations)).saveConfigAsync();
+
+        // Verify synchronous saveConfig was NOT called (except maybe in constructor? No, constructor calls config.getKeys)
+        // ItemSort constructor calls getConfig().getKeys(), not saveConfig().
+        // So saveConfig() should be called 0 times.
+        verify(itemManager, times(0)).saveConfig();
+    }
+}