Skip to content

Conversation

@Whoops
Copy link
Contributor

@Whoops Whoops commented Jun 12, 2025

Summary of changes

Asana Ticket: NO TICKET

[Please include a brief description of what was changed]

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@Whoops Whoops requested a review from jzimbel-mbta June 12, 2025 19:04
data =
ExportUpload.extract_data_from_upload(
%{path: "#{@export_dir}/#{export}"},
"uid-#{System.unique_integer([:positive])}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first theory was that with the tests all writing to the same directory, maybe two different tests were clobbering each other's data. This didn't fix the problem, but I left it in since it seemed like good practice.

@Whoops
Copy link
Contributor Author

Whoops commented Jun 12, 2025

To replicate the failure locally, you can checkout master and run while mix test test/arrow/hastus/export_upload_test.exs; do :; done (assuming you're using bash or a bash-compatible shell). I'd estimate around 1 in 10 fail.

@Whoops Whoops marked this pull request as ready for review June 12, 2025 19:06
@Whoops Whoops requested a review from a team as a code owner June 12, 2025 19:06
@Whoops
Copy link
Contributor Author

Whoops commented Jun 12, 2025

Here's a CI run that had the failure.

Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just leaving a "comment" review for now to get github slackbot to stop reminding about this PR until we get some input from Shanti on #1271 next week in two weeks.

@jzimbel-mbta jzimbel-mbta merged commit 404cf80 into master Aug 6, 2025
5 checks passed
@jzimbel-mbta jzimbel-mbta deleted the wh-intermittent-test-failures branch August 6, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants