Feature/mps cli python file filter for file per root persistency #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property is not found instead of throwing an exception
…and get_node_by_uuid to speed up the functions if there are called multiple times for big repos
… the caller to decide which mpsr files should be parsed
…per_root_persistency
danielratiu
reviewed
Apr 12, 2024
Member
danielratiu
left a comment
danielratiu
left a comment
There was a problem hiding this comment.
the code looks good - however, it would be great to add a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mps cli python: add a new file filter for parsing models with file per root persistency that allows the caller to decide which mpsr files should be parsed and which should be ignored