Web-Specifc Optimization with PWA Features #118 Level 3#126
Web-Specifc Optimization with PWA Features #118 Level 3#126may-tas merged 4 commits intomay-tas:mainfrom
Conversation
Our Pull Request Approval ProcessThanks for contributing! ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
|
@preetidas60 Please remove the UI changes, not needed for this PR. |
|
@may-tas I only made edits to the main screen UI because the bottom horizontal box (that displays the effects) wasn’t scrollable horizontally on web. I added logic to make it scrollable only on web, it won’t affect phones or other platforms. I’ve tested it thoroughly, and there are no function breaks or any issues caused by this change. |
|
@preetidas60 Please add a screen recording showing all the changes and features implemented |
|
@may-tas I have added the video which shows the changes in the bottom UI as I have mentioned and also the shortcuts like ctrl z and ctrl s and few others. |
lib/utils/offline_storage.dart
Outdated
There was a problem hiding this comment.
@preetidas60 This class hasn't been used anywhere, nor its methods, many methods in this file offline_storage.dart is not used, I don't think this file is necessary, please remove it.
lib/utils/web_utils.dart
Outdated
There was a problem hiding this comment.
@preetidas60 promptInstall method isn't used anywhere, remove it.
| } | ||
|
|
||
| /// Keyboard shortcut handler for web platform | ||
| class KeyboardShortcuts extends StatelessWidget { |
There was a problem hiding this comment.
@preetidas60 Could you please explain how this is working? I don't see any references to this class in any other files. Additionally, I would like an explanation of the keyboard shortcuts, as this is the main functionality for this PR and needs to be operational.
There was a problem hiding this comment.
@may-tas The KeyboardShortcuts widget is already wrapping the entire CanvasScreen (line 90), so all shortcuts like Ctrl+S, Ctrl+Z, Ctrl+D etc. are fully functional on web - each shortcut calls handler functions that trigger the corresponding CanvasCubit methods.
|
@preetidas60 please resolve the comments. |
|
@may-tas I have done all the changes. |
|
@preetidas60 LGTM, merging. |
What kind of change does this PR introduce?
Feature enhancement - Web-specific optimizations and Progressive Web App (PWA) implementation
Issue Number:
Fixes #118
Summary
This PR introduces comprehensive web-specific optimizations and PWA capabilities to the TextEditingApp, improving the web experience and enabling offline functionality.
Video
demo.webm
Key Changes:
lib/utils/offline_storage.dart) to persist user data locallylib/utils/web_utils.dart) for platform detection and optimizationflutter_service_worker.jsfor asset caching and offline functionalityweb/manifest.jsonwith proper PWA metadata for better app-like experienceweb/index.htmlfor better web performance and PWA supportBenefits:
Does this PR introduce a breaking change?
No. This PR is backward compatible and only adds new web-specific features without modifying existing functionality for other platforms.
Other information
Technical Details:
Testing Recommendations:
Have you read the contributing guide, README.md, code of conduct?
Yes