Skip to content

pixel overloading fixed#120

Merged
may-tas merged 2 commits intomay-tas:mainfrom
sandy4242:main
Oct 2, 2025
Merged

pixel overloading fixed#120
may-tas merged 2 commits intomay-tas:mainfrom
sandy4242:main

Conversation

@sandy4242
Copy link
Contributor

What kind of change does this PR introduce?

bugfix

Issue Number:

Fixes #109

Snapshots/Videos:

WhatsApp Image 2025-10-02 at 00 51 00_6f2cfcbd

Summary

fixes a pixel overloading issue

Does this PR introduce a breaking change?

minor bug fix

Other information

Have you read the contributing guide , README.md , code of conduct?

yes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Our Pull Request Approval Process

Thanks for contributing!

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

),
const SizedBox(height: 16),
Row(
Wrap(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main change

),
),
),
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the existing page stuff

@sandy4242
Copy link
Contributor Author

@may-tas i have used wrap... and as you might be seeing too many changes because of line and spacing which i have added a new commit d3c07e4...

@may-tas
Copy link
Owner

may-tas commented Oct 1, 2025

@sandy4242 I recommend a better option: instead of removing the Row, you can simply add a SingleChildScrollView on top of the Row widget, and it will work perfectly.

@may-tas
Copy link
Owner

may-tas commented Oct 1, 2025

Btw,
@sandy4242, have you registered for the Hacktoberfest?
if yes then i will add the hacktoberfest-accepted label on this PR.
if you haven't registered yet, you can still register.

@sandy4242
Copy link
Contributor Author

@may-tas yes i am registered ...

@may-tas
Copy link
Owner

may-tas commented Oct 2, 2025

@sandy4242
instead of removing the Row, you can simply add a SingleChildScrollView on top of the Row widget, and it will work perfectly.

@may-tas may-tas added the hacktoberfest-accepted This indicates that a pull request (PR) is considered valid for Hacktoberfest 2025. label Oct 2, 2025
@may-tas may-tas merged commit a7df812 into may-tas:main Oct 2, 2025
@sandy4242
Copy link
Contributor Author

@may-tas close kar diya??
and whats the difference between hacktoberfest and hacktoberfest accepted?

@may-tas
Copy link
Owner

may-tas commented Oct 2, 2025

@sandy4242 Yes I have merged your PR.
hacktoberfest-accepted is a label suggested by the Hacktoberfest team for open-source repositories. It indicates that your PR is valid and not spammy or fake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc25 hacktoberfest-accepted This indicates that a pull request (PR) is considered valid for Hacktoberfest 2025. level1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report for pixel overflowing

2 participants

Comments