Conversation
Our Pull Request Approval ProcessThanks for contributing! ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
|
@zxnb01 have you registered for the hacktoberfest? |
|
you can also register right now, if you haven't. |
|
Yes I registered for hacktoberfest |
Added a TODO comment for future brush type render methods.
|
Also, how is the level label being assigned in gssoc? @may-tas |
|
@zxnb01, the project admin primarily determines the level to assign a PR, and the level system carries points.
I assign levels tasks based on the complexity of the pull request (PR) rather than the number of lines added. Additionally, if contributors are not active, I may raise the level of the issues and open more high-level topics, even if they are easier to implement. This approach is necessary to attract more contributors and encourage participation in open-source projects. |
|
@zxnb01 looks good, merging. I hope you are also contributing to other projects or organizations. The quicker you reach 6 merged pull requests, the better your chances are of winning a T-shirt, as they are limited to the first 10,000 contributors. Best of luck! |
|
yay thanks! |
What kind of change does this PR introduce?
Feature — enhancement of the drawing canvas with multiple brush types (Brush and Marker) and improved toolbar access.
Issue Number:
Fixes #108
Snapshots/Videos:
Screen.Recording.2025-09-30.223316.mp4
Summary
This PR expands the drawing tools by introducing a dedicated "Brush Types" selection and adding a Marker tool alongside the existing Brush. The draw button now exposes brush options in the toolbar (compact 2x1 grid) so users can pick the tool before or during drawing. Both tools preserve existing color and stroke controls.
Key changes:
Brush:solid, opaque strokes (FilterQuality.high)Marker:semi-transparent strokes (~70% opacity), wider by default (1.5x), medium filter qualitycurrentBrushTypetracked in canvas state and managed via cubit (setBrushType)_createPaintForBrushDoes this PR introduce a breaking change?
Nope
Other information
Future work: we can add additional brush types (watercolor, oil paint, spray, charcoal, highlighter, pencil) using the same pattern (enum + paint configuration + optional custom rendering). Do you want me to proceed and add those next?
Have you read the contributing guide , README.md , code of conduct?
Yes