Skip to content

Added Shadows Effect Feature#111

Merged
may-tas merged 4 commits intomay-tas:mainfrom
preetidas60:feature-shadows-effect
Oct 5, 2025
Merged

Added Shadows Effect Feature#111
may-tas merged 4 commits intomay-tas:mainfrom
preetidas60:feature-shadows-effect

Conversation

@preetidas60
Copy link
Contributor

@preetidas60 preetidas60 commented Sep 30, 2025

What kind of change does this PR introduce?

Feature - Text Shadow & Glow Controls

Issue Number:

Fixes #74

Screenshots:

image

Video:

shadow.mp4

Summary

Implements text shadow and glow effects with customizable color, blur radius, and offset controls. Users can now add visual depth and highlights to text items through a new Shadow Controls panel integrated into the text editing toolbar.

Does this PR introduce a breaking change?

No

Other information

  • Added ShadowsControls widget for shadow customization UI
  • Extended TextItemModel with shadow properties
  • Real-time preview of shadow changes
  • Shadows disabled by default for existing text items

Have you read the contributing guide, README.md, code of conduct?

Yes

Checklist:

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Comments added for complex logic
  • Documentation updated if needed
  • No new warnings generated
  • Tests added/updated (if applicable)
  • All tests passing
  • Screenshots/videos added above

@github-actions
Copy link
Contributor

Our Pull Request Approval Process

Thanks for contributing!

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@may-tas
Copy link
Owner

may-tas commented Sep 30, 2025

@preetidas60 attach a screen recording please.

@preetidas60
Copy link
Contributor Author

@may-tas I have attached the screen recording.

@may-tas
Copy link
Owner

may-tas commented Oct 1, 2025

@preetidas60
According to your video, the shadow options panel is not intuitive. It resembles standard labels and does not feel like buttons. Instead of a large dialog, consider implementing a panel for shadow colors similar to how the background colors panel is implemented—simple and intuitive with icons. Additionally, in the effects panel, the horizontal and vertical sliders are not functioning properly; please fix that.

Also, rather than using purple colors, try to align with the overall UI of the app by using shades of black, white, and grey.

Lastly, could you clarify the purpose of the glitter icon? The video does not explain its functionality.

@may-tas
Copy link
Owner

may-tas commented Oct 1, 2025

@preetidas60 have you registered for the hacktoberfest?
if yes then i will add the hacktoberfest-accepted label on this PR.
if you haven't registered yet, you can still register.

@preetidas60
Copy link
Contributor Author

@preetidas60 have you registered for the hacktoberfest? if yes then i will add the hacktoberfest-accepted label on this PR. if you haven't registered yet, you can still register.

Thanks for recommending Hacktoberfest, i have just registered in it, and yes you can label it as hacktoberfest-accepted as well and I am working on the suggested changes, will commit changes by tomorrow

@preetidas60
Copy link
Contributor Author

@may-tas I have made the changes and also updated the video in the PR.

@may-tas
Copy link
Owner

may-tas commented Oct 2, 2025

@preetidas60
Can you add more space(const SizedBox(width: 25)) between the highlight colors and the 'shadow' name? They are too close together. Also, what does the sparkle icon do, and what is the purpose of the dropper icon?

Rest everything is cool.

@may-tas may-tas added level2 gssoc25 hacktoberfest-accepted This indicates that a pull request (PR) is considered valid for Hacktoberfest 2025. labels Oct 2, 2025
@preetidas60
Copy link
Contributor Author

preetidas60 commented Oct 4, 2025

@may-tas I have added the space between the highlight and shadow.
The Sparkle icon opens the Shadow presets box which lets you choose "soft shadow", "medium shadow", and others....
The droper icon opens a box which lets you choose more colors.

@may-tas
Copy link
Owner

may-tas commented Oct 4, 2025

@preetidas60 I think you have allowed selecting shadow colors on the font controls bar as you said.
So we don't need the same option on shadow settings.

You can remove the color options from this.

IMG_20251004_115323.jpg

@preetidas60
Copy link
Contributor Author

@may-tas I have removed the colors options from here.
image

@may-tas
Copy link
Owner

may-tas commented Oct 5, 2025

@preetidas60 thanks, merging.

@may-tas may-tas merged commit f37fc37 into may-tas:main Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc25 hacktoberfest-accepted This indicates that a pull request (PR) is considered valid for Hacktoberfest 2025. level2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Text Shadow & Glow

2 participants

Comments