Feat/add python binding #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No longer used deptecrated Struct * add clippy allow for unsafe code
* Function is no longer async. * No longer has opaque C type. * Therefore, can be C FFI safe again.
Requires: * justfile * uv
Contributor
Author
|
Closing in favour of #15 as I realised that this could work fine just branching off main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Feature
Add python binding for dockpack pull functionality by using
unpack_files_from_image_cfunction.Use CFFI & Maturin (not Py03).
justfile (like a Makefile) that can be used with uv to test the bindings.
This is a branch off of Refactor/use anyhow errors in core-dockpack #12 . So, it has that PR's changes too. That PR fixes some things so that the FFI can work.
Future work: