Skip to content

Conversation

@TomBurdge
Copy link
Contributor

@TomBurdge TomBurdge commented May 9, 2025

Change

  • Pushes the built docker image to a remote repo. (just like docker push
  • Tests will not yet pass - needs to be able to auth to the remote image in the push test. We will need a strategy to formulate this in the test - I will give it some thought but would love some input. Might see if I can pinch anything from the bollard tests.

Reason for Change

  • docker push pushes to remote repo. I suppose docpack push should too.

PR status/Future improvement

  • I'm going to wait until the refactoring PR is merged until finishing this off. Then, it will be straightforward to merge in its changes and remove the new .expect here.
  • Might want to add a feature flag for push/not push to remote, if someone wants to build the image locally and not push (e.g. to serve/test the image locally). However, we wouldn't need that flag if we made dockpack build do what I expect; build the image (like dockpack push does now). Right now, dockpack build only "builds" the docker file itself.

@maxwellflitton maxwellflitton merged commit ad872c3 into maxwellflitton:main May 28, 2025
@maxwellflitton
Copy link
Owner

@TomBurdge thanks for this pull request I'm really grateful for your contributions. Will do another release soon. Also getting dates arranged for an all day hackathon for the meetup so hopefully see you there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants