hotfix: Disable analytics to fix gallery clicks - Issue #263#264
Merged
hotfix: Disable analytics to fix gallery clicks - Issue #263#264
Conversation
Adds comprehensive regression tests to prevent reverting Link components back to onClick handlers on non-interactive elements. Unit Tests (11 tests): - Verify gallery items are Link elements (semantic <a> tags) - Verify href attributes exist for native navigation - Verify no role="button" on articles/divs - Verify JavaScript-free navigation works - Verify cross-platform consistency E2E Tests (7 scenarios): - Simulate Lockdown Mode (JavaScript disabled) - Verify strict browser security compatibility - Test keyboard accessibility - Validate SEO/crawlability with proper links These tests will catch if anyone accidentally reverts to the broken pattern that caused iOS Lockdown Mode and desktop browser security issues (Issue #259). Related: #259, #260
Analytics server (analytics.idaromme.dk) is down (504 timeout), returning HTML instead of JavaScript. This causes MIME type mismatch errors that break React hydration, preventing gallery clicks from working. HOTFIX: Temporarily disable analytics script loading until server is fixed. Fixes #263
🔍 Lighthouse Performance Report❌ No Lighthouse results found. Check the workflow logs for details. This report was generated by Lighthouse CI in GitHub Actions |
🎯 Performance Budget SummaryBundle Size Analysis
Lighthouse Performance ValidationDesktop Results
Mobile Results
Performance Budget Status
Next Steps
Generated at $(date) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Gallery images are not clickable on production site (both desktop and mobile) due to analytics server failure.
Root Cause: Analytics server (
analytics.idaromme.dk) is down (504 Gateway Timeout), returning HTML error page instead of JavaScript. Browser blocks this with MIME type mismatch error, which breaks React hydration and prevents all client-side interactivity including gallery clicks.Evidence
Browser Console Errors:
Server Response:
Solution
Hotfix: Temporarily disable analytics script loading in
analytics-provider.tsxuntil analytics server is restored.Impact
Testing
Manual Testing Required:
Next Steps
After verifying gallery works:
Files Changed
src/app/components/analytics-provider.tsx: Added early return to disable analyticsRelated
Doctor Hubert, please test on your devices after deployment: