fix(mobile): Resolve mobile gallery items not clickable - Issue #257#258
Merged
fix(mobile): Resolve mobile gallery items not clickable - Issue #257#258
Conversation
…mage overlay Issue #257: Mobile gallery items were not navigating to project pages when clicked/tapped. Root cause: - FirstImage LCP optimization overlay was blocking mobile gallery interactions - z-index hierarchy allowed FirstImage to overlay gallery items - position: absolute caused FirstImage to overlay first gallery item Fix implemented: 1. Mobile gallery items: Added position: relative and z-index: 10 for proper layering 2. FirstImage on mobile: Changed to position: relative with z-index: -1 (behind gallery) 3. Added pointer-events: none !important to prevent any click blocking 4. Maintained document flow while ensuring gallery items are clickable Testing: - Added comprehensive E2E test suite (mobile-gallery-clicks.spec.ts) - Tests verify clicking/tapping on mobile gallery items navigates correctly - Tests cover multiple viewports (iPhone SE, iPhone 12, Android) - Tests verify FirstImage doesn't block interactions - Tests verify proper touch target sizes (WCAG 2.1) - All 131 Mobile Chrome e2e tests passing Files changed: - src/styles/mobile/gallery.css: Fixed z-index and positioning for mobile - src/styles/desktop/gallery.css: Added pointer-events: none !important - src/components/server/FirstImage.module.css: Ensured pointer-events from start - tests/e2e/mobile-gallery-clicks.spec.ts: New comprehensive test suite
🔍 Lighthouse Performance Report❌ No Lighthouse results found. Check the workflow logs for details. This report was generated by Lighthouse CI in GitHub Actions |
🎯 Performance Budget SummaryBundle Size Analysis
Lighthouse Performance ValidationDesktop Results
Mobile Results
Performance Budget Status
Next Steps
Generated at $(date) |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔍 Lighthouse Performance Report❌ No Lighthouse results found. Check the workflow logs for details. This report was generated by Lighthouse CI in GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Projects don't open when clicked/tapped on mobile gallery. This is a critical UX bug for a portfolio site - users cannot browse the work.
Fixes #257
Root Cause
FirstImage LCP optimization overlay was blocking mobile gallery interactions due to:
position: absolutecaused FirstImage to overlay the first gallery itempointer-events: none, the layering blocked interactionsSolution Implemented (TDD Approach)
1. Test-Driven Development
mobile-gallery-clicks.spec.ts)2. Technical Changes
Mobile Gallery Items
FirstImage on Mobile
FirstImage Module CSS
Testing
New Test Suite
Created comprehensive E2E test suite:
tests/e2e/mobile-gallery-clicks.spec.tsTests cover:
Test Results
Files Changed
src/styles/mobile/gallery.css: Fixed z-index and positioningsrc/styles/desktop/gallery.css: Addedpointer-events: none !importantsrc/components/server/FirstImage.module.css: Ensured pointer-events from starttests/e2e/mobile-gallery-clicks.spec.ts: Comprehensive test suite (new)Verification Steps
Impact
Agent Validations Required