fix: add support for Rollup version 3#125
Closed
alan-agius4 wants to merge 1 commit intomaxdavidson:masterfrom
Closed
fix: add support for Rollup version 3#125alan-agius4 wants to merge 1 commit intomaxdavidson:masterfrom
alan-agius4 wants to merge 1 commit intomaxdavidson:masterfrom
Conversation
This fixes incorrect peer deps ``` +-- rollup-plugin-sourcemaps@0.6.3 | +-- @rollup/pluginutils@3.1.0 | | `-- rollup@3.5.1 deduped invalid: "^1.20.0||^2.0.0" from node_modules/rollup-plugin-sourcemaps/node_modules/@rollup/pluginutils | `-- rollup@3.5.1 deduped ```
|
We just ran across this in an update to our repo @js-temporal/polyfill. Thanks @alan-agius4 for saving us the hassle of filing the same PR! If anyone else has the same issue, before this PR is merged here's how we worked around it in our package.json: "overrides": {
"@rollup/pluginutils": "^5.0.2"
}, |
|
Fixes #127 |
|
@maxdavidson what blocks this PR from being merged? |
|
@maxdavidson an ETA? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes incorrect peer deps