Open
Conversation
Owner
|
Thanks for the contribution! Everything looks good, but I'm not quite sure I want to merge these into the base repo at this time, as I would like to keep the core system's method signature low. In the future, I want to actually create a secondary library containing the more advanced implementations to be packaged as font-utils-views (or something along those lines, similar to how Google has split their play-services libraries) as to not include more than the developer needs to accomplish their tasks. I'm going to leave this pull request open, though, and I'll merge these into that when I get the chance to split the library. |
Author
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added four widgets.. please monitor code changes and merge if u think it is usefull