Added support for using GET requests and fixed blank error dialogs#1
Open
kendallb wants to merge 1 commit intomattrand:masterfrom
Open
Added support for using GET requests and fixed blank error dialogs#1kendallb wants to merge 1 commit intomattrand:masterfrom
kendallb wants to merge 1 commit intomattrand:masterfrom
Conversation
…ults can be cached in the browser. There is no need for a POST if the json property is not set, and if the developer knows their tree data is safe they can enable JSON get support. More importantly this will also work if you the dataUrl points to an HTML block (so Google can index it) and it can be cached aggressively browser side. I also modified the error handler to not display an error message if the error response text is empty. This is a workaround for issues in Firefox where Firefox will cancel any pending AJAX requests when a user browsers away from a page, so if the AJAX request for the EasyTree data is still executing when they click (I click very fast as time! lol) then you get an empty error dialog that pops up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for using GET requests to get node data so that the results can be cached in the browser. There is no need for a POST if the json property is not set, and if the developer knows their tree data is safe they can enable JSON get support. More importantly this will also work if you the dataUrl points to an HTML block (so Google can index it) and it can be cached aggressively browser side.
I also modified the error handler to not display an error message if the error response text is empty. This is a workaround for issues in Firefox where Firefox will cancel any pending AJAX requests when a user browsers away from a page, so if the AJAX request for the EasyTree data is still executing when they click (I click very fast as time! lol) then you get an empty error dialog that pops up.