Clean up getmodels.py #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beebdev
referenced
this pull request
in beebdev/RUscripts-R9
Nov 7, 2022
Changes include: -Replaced AXI-lite interface implementation -Using AXIS-FIFO and FIFO-AXIS adapters to transfer data to and from FIFO -Added Python testbench (cocotb) to verify behaviour of system -Added driver repo as submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested in squiggle-level analysis of nanopore data, and your script didn't work for the limited/old collection of files I had. The second column of the model files would be a "variant", not a mean. I changed the code to use Pandas for reading HDF and writing CSV. You may use
header=Falsein the calls to pd.write_csv if you want to omit the header row.This version should also be robust to column reordering in future/past fast5 formats.