Open
Conversation
Contributor
empyriumz
commented
Feb 13, 2025
empyriumz
commented
- fixed and improved the device and data management in gp.py.
- removed the FixedNoiseGP in gp.py as it was removed in BoTorch 0.13 and replaced it with the equivalent SingleTaskGP instance.
- changed the default acquisition_function to LogEI (see doc: NOTE: It is strongly recommended to use LogExpectedImprovement instead of regular EI...).
…tps://botorch.readthedocs.io/en/latest/acquisition.html#botorch.acquisition.analytic.ExpectedImprovement). 2. fixed and improved the device and data mangement in gp.py. 3. removed the FixedNoiseGP in gp as it is removed in BoTorch 0.13 and replaced it with the equivalent SingleTaskGP instance.
…regularization denominator (k-neighor mean instead of nearest neighbor); PBC for anistropic not working yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.