[#96] Replacing bou.ke/monkey with Gomock #215
+652
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.sum
# Conflicts: # go.sum
nevyangelova
approved these changes
Jan 5, 2026
Contributor
nevyangelova
left a comment
nevyangelova
left a comment
There was a problem hiding this comment.
We should probably do a regression test!
Author
|
Completely agreed! It would be good to make sure nothing is flying under the radar |
ogi-m
added
the
Setup Cloud Test Server
|
Plugin Spinwick PR #215 🎉 Test server created! Access here: https://confluence-pr-215-btn46.test.mattermost.cloud
The test server was created successfully, but there was an issue installing or enabling the plugin automatically:
You can manually install the plugin:
Future commits will still attempt to automatically update the plugin. Installation ID: Credentials: Posted securely in this Mattermost channel - Look for PR #215 |
ogi-m
added
4: Reviews Complete
|
Test server destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-opening the #197 PR because of the failed pipelines and checks that are likely happening due to them being originally opened from a fork. If workflow runs are successful I will be closing the original PR in favor of this one
This PR removes the bou.ke/monkey that is used to mock functions in testing, with the necessary GoMock-compatible interfaces and mocks
The PR also contains the addition of test various constants that are shared across tests for better clarity
Ticket Link
Fixes #96