E2E: Skip the notification prompt when NODE_ENV= test #3512
+2,705
−1,649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasserfaraazkhan
added
E2E/Run
yasserfaraazkhan
changed the title
| name: Electron Playwright Tests | ||
|
|
||
| on: | ||
| pull_request: |
Contributor
Author
There was a problem hiding this comment.
when we add label it was creating multiple jobs in delivery platform. I've remove this trigger type
saturninoabril
approved these changes
Sep 23, 2025
Contributor
saturninoabril
left a comment
saturninoabril
left a comment
There was a problem hiding this comment.
Thanks @yasserfaraazkhan!
devinbinnie
reviewed
Sep 23, 2025
| // For certain permission types, we need to confirm with the user | ||
| if (authorizablePermissionTypes.includes(permission) || isExternalFullscreen) { | ||
| // In test mode, do not show dialog, always allow | ||
| if (process.env.NODE_ENV === 'test') { |
Contributor
Author
There was a problem hiding this comment.
@enzowritescode double checking with you on this code
This was referenced Nov 14, 2025
- Remove JS code from yml workflow files
Member
|
@yasserfaraazkhan Where are we on the changes here? |
Contributor
Author
@devinbinnie I've run the tests. Can you check the reports? |
This reverts commit 6f7f0a5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the Electron end-to-end (E2E) testing infrastructure, focusing on increased reliability, better cross-platform support (especially for macOS-15), and improved test stability. The changes span CI workflow enhancements, E2E environment robustness, dependency updates, and targeted test reliability fixes.
CI Workflow Improvements:
.github/workflows/e2e-functional.ymlto consolidate and generalize status updates for all platforms, usingactions/github-scriptto dynamically update commit statuses for each OS, and removed redundant jobs for individual platforms. [1] [2].github/workflows/e2e-functional-template.ymlby adding explicit cleanup of Electron system folders, ensuring Electron.app is properly configured and signed on macOS-15, and improving build and test steps for reliability.NODE_ENV: "test"in workflow environments for consistency across runs.E2E Environment Robustness:
e2e/modules/environment.jsto remove Electron single-instance lock files on macOS, preventing launch failures, and switched to more robust directory removal methods. [1] [2] [3]Dependency Updates:
e2e/package.json, including@aws-sdk,axios,chai,fast-xml-parser,mochawesome,nan,node-abi,playwright, andmochawesome-report-generator, to address security, compatibility, and feature improvements.Test Stability and Reliability:
deeplink.test.jsandfocus.test.jsto handle asynchronous server map population and slow initialization, especially on Windows and macOS, reducing flaky test failures. [1] [2] [3]Other Notable Changes:
These changes collectively make the E2E testing pipeline more robust, especially on macOS-15, and reduce sources of test flakiness across platforms.