Solves issues related to transitionArchetype #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR. Are you able to add a test to make sure that this fixes the issue? |
Splits some of the logic from transitionArchetype into a separate function removeFromArchetype that can be utilized by both transitionArchetype and executeDespawn. Removes executeDespawn's dependency on transitionArchetype, solving the bug presented in matter-ecs#164.
TheyCallMeRyan
changed the title
Author
|
Added another commit resolving the issue in #164 as well |
Ukendio
approved these changes
Aug 15, 2025
Member
|
Can we please edit the title to reflect the changes that are happening and link appropriately with closing keywords before merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the oldArchetype is the same as the new archetype then don't do any transition
Related issues
See: #157
Additional comments