fix(view): get should be nullable & should not wrap a singular component in a LuaTuple
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent in a `LuaTuple`
sasial-dev
force-pushed
the
fix/view-types
branch
from
c58a107 to
805e8c1
Compare
Ukendio
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
view:getshould return a nullable array and should not return aLuaTupleif there is only one component.Related issues
Discussed in #matter-types at https://discord.com/channels/1234249974959702056/1234254541730353242/1279274683463630908
Additional comments
N/A. Should be a nice simple PR :)