Skip to content

Do not throw on duplicate close calls#29

Open
mxmlnkn wants to merge 1 commit intomatteomattei:masterfrom
mxmlnkn:fix-close
Open

Do not throw on duplicate close calls#29
mxmlnkn wants to merge 1 commit intomatteomattei:masterfrom
mxmlnkn:fix-close

Conversation

@mxmlnkn
Copy link
Contributor

@mxmlnkn mxmlnkn commented Oct 12, 2024

Especially because there is no closed test method, it should be possible to call close multiple times. Currently, this throws an exception:

PySquashfsImage/__init__.py", line 131, in close
    self._fd.close()
    ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'close'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant